Implement support for ReturnValuesOnConditionCheckFailure #2688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagnir
force-pushed
the
ddb-enhanced-returnvalues
branch
7 times, most recently
from
96aa329 to
efb4816
Compare
dagnir
changed the title
dagnir
force-pushed
the
ddb-enhanced-returnvalues
branch
8 times, most recently
from
c58acda to
c57df6d
Compare
This change gives customer the ability to specify ReturnValuesOnConditionCheckFailure on the TransactWriteItems operation, i.e. for PutItem, DeleteItem, UpdateItem, and ConditionCheck. In order to support this feature, new Transact*EnhancedRequest objects have been introduced because ReturnValuesOnConditionCheckFailure does not make any sense for the non-TransactWrite operations. Conversely, other options on the non-transact versions like ReturnConsumedCapacity do not make sense for the Transact* versions. As a result of "splitting" off the TransactWrite versions of the operations, the methods on TransactWriteItemsEnhancedRequest that take the non-transact versions have been deprecated. Fixes aws#2283
dagnir
force-pushed
the
ddb-enhanced-returnvalues
branch
from
c57df6d to
ec5b871
Compare
|
Duplication failure is expected; it's flagging the duplication of the |
...db-enhanced/src/main/java/software/amazon/awssdk/enhanced/dynamodb/model/ConditionCheck.java
Show resolved
Hide resolved
...n/java/software/amazon/awssdk/enhanced/dynamodb/model/TransactDeleteItemEnhancedRequest.java
Outdated
Show resolved
Hide resolved
...n/java/software/amazon/awssdk/enhanced/dynamodb/model/TransactDeleteItemEnhancedRequest.java
Show resolved
Hide resolved
Comment on lines
+98
to
+99
| * {@link ReturnValuesOnConditionCheckFailure#UNKNOWN_TO_SDK_VERSION}. The raw value returned by the service is | ||
| * available from {@link #returnValuesOnConditionCheckFailureAsString}. |
There was a problem hiding this comment.
Nit: This Javadoc seems to be somewhat redundantly referring to itself.
...n/java/software/amazon/awssdk/enhanced/dynamodb/model/TransactUpdateItemEnhancedRequest.java
Show resolved
Hide resolved
...n/java/software/amazon/awssdk/enhanced/dynamodb/internal/operations/DeleteItemOperation.java
Show resolved
Hide resolved
...n/java/software/amazon/awssdk/enhanced/dynamodb/model/TransactWriteItemsEnhancedRequest.java
Show resolved
Hide resolved
...n/java/software/amazon/awssdk/enhanced/dynamodb/model/TransactWriteItemsEnhancedRequest.java
Outdated
Show resolved
Hide resolved
...n/java/software/amazon/awssdk/enhanced/dynamodb/model/TransactWriteItemsEnhancedRequest.java
Outdated
Show resolved
Hide resolved
| try { | ||
| enhancedClient.transactWriteItems(transactWriteItemsEnhancedRequest); | ||
| fail("Expected TransactionCanceledException to be thrown"); | ||
| } catch(TransactionCanceledException e) { |
There was a problem hiding this comment.
Nit: Recommend using assertThatExceptionOfType(..) instead.
Bennett-Lynch
approved these changes
Sep 3, 2021
cenedhryn
reviewed
Sep 3, 2021
...n/java/software/amazon/awssdk/enhanced/dynamodb/internal/operations/UpdateItemOperation.java
Show resolved
Hide resolved
cenedhryn
approved these changes
Sep 3, 2021
Bennett-Lynch
approved these changes
Sep 3, 2021
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixes #2283
Description
This change gives customer the ability to specify
ReturnValuesOnConditionCheckFailure on the TransactWriteItems operation, i.e.
for PutItem, DeleteItem, UpdateItem, and ConditionCheck.
In order to support this feature, new Transact*EnhancedRequest objects have been
introduced because ReturnValuesOnConditionCheckFailure does not make any sense
for the non-TransactWrite operations. Conversely, other options on the
non-transact versions like ReturnConsumedCapacity do not make sense for the
Transact* versions.
As a result of "splitting" off the TransactWrite versions of the operations, the
methods on TransactWriteItemsEnhancedRequest that take the non-transact versions
have been deprecated.
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsLicense