Add short type support #2395
Merged
Add short type support #2395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joviegas
reviewed
Apr 15, 2021
...ol-tests-core/src/main/java/software/amazon/awssdk/protocol/reflect/ShapeModelReflector.java
Show resolved
Hide resolved
joviegas
reviewed
Apr 16, 2021
There was a problem hiding this comment.
For completeness we need to Add Short support in core/protocols/aws-query-protocol/src/main/java/software/amazon/awssdk/protocols/query/internal/unmarshall/QueryProtocolUnmarshaller.java
Also please add corresponding test case in //test/protocol-tests-core/src/main/resources/software/amazon/awssdk/protocol/suites/cases/query-output.json
|
Kudos, SonarCloud Quality Gate passed! |
joviegas
approved these changes
Apr 16, 2021
|
@all-contributors please add @duy3101 for code. |
|
I've put up a pull request to add @duy3101! 🎉 |
aws-sdk-java-automation
added a commit
that referenced
this pull request
Feb 20, 2023
…1d256208e Pull request: release <- staging/32ed0c96-9528-473c-a9c4-3ac1d256208e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
My service requires short type for model generation. This pr intends to support that.
Motivation and Context
Without short support, the model generation fails at run time because the MarshallingType default to null.
Testing
Added unit tests and mvn install
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsLicense