Skip to content

Fix eventstream legacy generation #2217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 22, 2020
Merged

Conversation

dagnir
Copy link
Contributor

@dagnir dagnir commented Dec 21, 2020

Description

Legacy generation uses the shape name as the event name. Transcribe Streaming
has a member event named "TranscriptEvent", but its shape is
"MedicalTranscriptEvent". This only affected interfaces, marshalling/marshalling
is okay.

Motivation and Context

Bug fix.

Testing

Added a new test.

Checked the diffs:

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

Legacy generation uses the shape name as the event name. Transcribe Streaming
has a member event named "TranscriptEvent", but its shape is
"MedicalTranscriptEvent". This only affected interfaces, marshalling/marshalling
is okay.
"EventOne": {
"TheEventOne": {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: legacy uses event shape name, so this caused a clash because we generated two "visitEventOne" methods; one is because the non legacy event was called "eventOne", and the legacy customized one had a shape name of "EventOne"

@codecov-io
Copy link

Codecov Report

Merging #2217 (e0eddb1) into master (205ef25) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2217      +/-   ##
============================================
- Coverage     77.58%   77.58%   -0.01%     
  Complexity      335      335              
============================================
  Files          1230     1230              
  Lines         38692    38697       +5     
  Branches       3043     3043              
============================================
+ Hits          30019    30022       +3     
- Misses         7214     7215       +1     
- Partials       1459     1460       +1     
Flag Coverage Δ Complexity Δ
unittests 77.58% <100.00%> (-0.01%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...eventstream/EventStreamVisitorBuilderImplSpec.java 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...stream/EventStreamVisitorBuilderInterfaceSpec.java 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...t/eventstream/EventStreamVisitorInterfaceSpec.java 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...ssdk/codegen/poet/model/EventStreamSpecHelper.java 93.75% <100.00%> (+0.64%) 0.00 <0.00> (ø)
...ssdk/core/internal/async/FileAsyncRequestBody.java 80.95% <0.00%> (-2.86%) 0.00% <0.00%> (ø%)
...ware/amazon/awssdk/utils/cache/CachedSupplier.java 90.24% <0.00%> (+2.43%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 205ef25...e0eddb1. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@dagnir dagnir merged commit d8c88cf into aws:master Dec 22, 2020
@dagnir dagnir deleted the fix-legacy-generation branch December 22, 2020 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants