-
Notifications
You must be signed in to change notification settings - Fork 914
Avoid costly metrics collection when metric collector is NoOpMetricCo… #2174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR! LGTM
Could you add a changelog entry? You can do so by running the scripts/new-change
script and following the instructions and then committing the new file created by the script in .changes/next-release
with your changes.
(Make sure the commits are squashed into one)
588f1a3
to
ab59a4a
Compare
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
Codecov Report
@@ Coverage Diff @@
## master #2174 +/- ##
=========================================
Coverage 77.44% 77.44%
Complexity 328 328
=========================================
Files 1222 1222
Lines 38304 38304
Branches 3018 3018
=========================================
+ Hits 29663 29665 +2
+ Misses 7185 7184 -1
+ Partials 1456 1455 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Kudos, SonarCloud Quality Gate passed! |
Skip importing ruleset-testing-core internally
…llector
Description
Avoid costly metrics collection when metric collector is NoOpMetricCollector.
Motivation and Context
Profiling with visualvm shows that collecting metrics takes resources.
Checklist
mvn install
succeedsLicense