Skip to content

REST-JSON: Unmarshall URI members from body #1996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2020

Conversation

dagnir
Copy link
Contributor

@dagnir dagnir commented Aug 21, 2020

Description

When unmarshalling, shapes that have marshalling locations set for a URI
component such as path or query paramter, they are located in the payload on
responses.

Motivation and Context

Bugfix.

Testing

  • Added protocols tests.
  • Ran integ tests.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

When unmarshalling, shapes that have marshalling locations set for a URI
component such as path or query paramter, they are located in the payload on
responses.
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

74.1% 74.1% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2020

Codecov Report

Merging #1996 into master will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1996      +/-   ##
============================================
+ Coverage     76.62%   76.67%   +0.05%     
  Complexity      225      225              
============================================
  Files          1112     1113       +1     
  Lines         33611    33686      +75     
  Branches       2599     2623      +24     
============================================
+ Hits          25755    25830      +75     
- Misses         6577     6582       +5     
+ Partials       1279     1274       -5     
Flag Coverage Δ Complexity Δ
#unittests 76.67% <100.00%> (+0.05%) 225.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...awssdk/protocols/json/internal/MarshallerUtil.java 100.00% <100.00%> (ø) 0.00 <0.00> (?)
.../internal/unmarshall/JsonProtocolUnmarshaller.java 95.69% <100.00%> (+0.04%) 0.00 <0.00> (ø)
...n/internal/unmarshall/JsonUnmarshallerContext.java 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...tomization/CodegenCustomizationProcessorChain.java 81.81% <0.00%> (-8.19%) 0.00% <0.00%> (ø%)
...on/awssdk/protocols/ion/AwsIonProtocolFactory.java 72.72% <0.00%> (-5.06%) 0.00% <0.00%> (ø%)
.../software/amazon/awssdk/core/sync/RequestBody.java 90.00% <0.00%> (-3.11%) 0.00% <0.00%> (ø%)
...ftware/amazon/awssdk/codegen/internal/Jackson.java 59.09% <0.00%> (-2.82%) 0.00% <0.00%> (ø%)
...on/awssdk/codegen/internal/DocumentationUtils.java 75.00% <0.00%> (-2.42%) 0.00% <0.00%> (ø%)
...nhanced/dynamodb/extensions/WriteModification.java 52.00% <0.00%> (-2.17%) 0.00% <0.00%> (ø%)
...ices/s3/internal/presigner/DefaultS3Presigner.java 88.88% <0.00%> (-1.92%) 0.00% <0.00%> (ø%)
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b6db7d...e1e1342. Read the comment docs.

@dagnir dagnir merged commit 97b6ddd into aws:master Aug 21, 2020
aws-sdk-java-automation added a commit that referenced this pull request Apr 22, 2022
…2cf5f7391

Pull request: release <- staging/8b8f7545-42c3-49c6-943a-8172cf5f7391
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants