Exposed both demandLowWatermark and demandHighWatermark of the HandlerSubscriber as configuration parameters

[marc-christian-schulze]

Description

Constructor parameters demandLowWatermark and demandHighWatermark of HandlerSubscriber are now exposed as configuration parameters streamingDemandLowWatermark and streamingDemandHighWatermark in the NettyConfiguration & NettyNioAsyncHttpClient$DefaultBuilder

Motivation and Context

#1936

Testing

Existing unit tests were executed and passed. In addition I've referenced the freshly built snapshot library in my custom project to validate the parameter configuration takes effect.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

Checklist

• I have read the CONTRIBUTING document
• Local run of mvn install succeeds
• My code follows the code style of this project
• My change requires a change to the Javadoc documentation
• I have updated the Javadoc documentation accordingly
• I have read the README document
• I have added tests to cover my changes
• All new and existing tests passed
• A short description of the change has been added to the CHANGELOG
• My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

• I confirm that this pull request can be released under the Apache 2 license

[sonarqubecloud]

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
1 Code Smell

75.0% Coverage
0.0% Duplication

The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

[codecov-commenter]

Codecov Report

Merging #1944 into master will increase coverage by 0.02%.
The diff coverage is 75.00%.

@@             Coverage Diff              @@
##             master    #1944      +/-   ##
============================================
+ Coverage     76.63%   76.66%   +0.02%     
  Complexity      225      225              
============================================
  Files          1112     1112              
  Lines         33651    33670      +19     
  Branches       2606     2621      +15     
============================================
+ Hits          25789    25813      +24     
+ Misses         6584     6582       -2     
+ Partials       1278     1275       -3     

Flag	Coverage Δ	Complexity Δ
#unittests	76.66% <75.00%> (+0.02%)	225.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ	Complexity Δ
...amazon/awssdk/http/SdkHttpConfigurationOption.java	0.00% <0.00%> (ø)	0.00 <0.00> (ø)
...awssdk/http/nio/netty/NettyNioAsyncHttpClient.java	70.83% <100.00%> (+0.71%)	0.00 <0.00> (ø)
...dk/http/nio/netty/internal/NettyConfiguration.java	94.44% <100.00%> (+0.69%)	0.00 <0.00> (ø)
.../http/nio/netty/internal/NettyRequestExecutor.java	73.02% <100.00%> (ø)	0.00 <0.00> (ø)
...o/netty/internal/nrs/HttpStreamsClientHandler.java	67.79% <100.00%> (ø)	0.00 <0.00> (ø)
...ttp/nio/netty/internal/nrs/HttpStreamsHandler.java	61.36% <100.00%> (+0.59%)	0.00 <0.00> (ø)
...nhanced/dynamodb/extensions/WriteModification.java	52.00% <0.00%> (ø)	0.00% <0.00%> (ø%)
...d/dynamodb/internal/extensions/ChainExtension.java	100.00% <0.00%> (ø)	0.00% <0.00%> (ø%)
...amodb/internal/operations/UpdateItemOperation.java	99.04% <0.00%> (+<0.01%)	0.00% <0.00%> (ø%)
...dynamodb/internal/operations/PutItemOperation.java	96.29% <0.00%> (+0.06%)	0.00% <0.00%> (ø%)
... and 8 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc6a2b3...121d672. Read the comment docs.

[marc-christian-schulze]

/cc @zoewangg @millems
Could you please review and advise what needs to be changed or how we can proceed?
This PR is so far the only known workaround to fix #953

[zoewangg]

Thank you for creating the PR and apologies for the delayed response. We will take a look shortly.

[millems]

Unfortunately I don't think we can accept this pull request, because it exposes a fairly low-level configuration component of the SDK that is subject to change in the future. We've followed up in the related issue to fix the problem that this PR was hoping to work around, so I'm hoping that will be sufficient.