Skip to content

Updated metric publishing to address internal review comments. #1931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2020

Conversation

millems
Copy link
Contributor

@millems millems commented Jun 29, 2020

Also fixed an issue where multiple parts of the SDK were ignoring the "alternate" request ID.

@millems millems force-pushed the millem/metrics-configuration branch 2 times, most recently from d8eab8e to 2899b7c Compare June 30, 2020 00:01
@dagnir dagnir force-pushed the millem/metrics-configuration branch from 2899b7c to eb581cd Compare June 30, 2020 21:13
@dagnir
Copy link
Contributor

dagnir commented Jun 30, 2020

Ran the integ tests and they are passing as well.

Also fixed an issue where multiple parts of the SDK were ignoring the "alternate" request ID.
@dagnir dagnir force-pushed the millem/metrics-configuration branch from 997f189 to 083a4d8 Compare June 30, 2020 23:09
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 4 Code Smells

84.7% 84.7% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@dagnir dagnir merged commit 33b3138 into sdk-metrics-development-2 Jun 30, 2020
aws-sdk-java-automation added a commit that referenced this pull request Feb 11, 2022
…f8f81c462

Pull request: release <- staging/7e6a3cfe-274c-4505-b32c-ff1f8f81c462
@millems millems deleted the millem/metrics-configuration branch October 19, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants