Skip to content

Fixing minor typo in CHANGELOG #1860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 29, 2020
Merged

Fixing minor typo in CHANGELOG #1860

merged 2 commits into from
May 29, 2020

Conversation

Carey-AWS
Copy link
Contributor

Description

CHANGELOG contains what appears to be a paste of a list of files in the Amazon Kendra GA announce item. Removed this.

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@codecov-commenter
Copy link

codecov-commenter commented May 22, 2020

Codecov Report

Merging #1860 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1860      +/-   ##
============================================
- Coverage     76.21%   76.21%   -0.01%     
  Complexity      187      187              
============================================
  Files          1076     1076              
  Lines         32564    32564              
  Branches       2569     2569              
============================================
- Hits          24820    24819       -1     
+ Misses         6487     6483       -4     
- Partials       1257     1262       +5     
Flag Coverage Δ Complexity Δ
#unittests 76.21% <ø> (-0.01%) 187.00 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
...nio/netty/internal/OldConnectionReaperHandler.java 81.81% <0.00%> (-9.10%) 0.00% <0.00%> (ø%)
...ine/stages/ApiCallAttemptTimeoutTrackingStage.java 93.10% <0.00%> (-6.90%) 0.00% <0.00%> (ø%)
...ssdk/core/internal/async/FileAsyncRequestBody.java 83.80% <0.00%> (-3.81%) 0.00% <0.00%> (ø%)
...o/netty/internal/utils/BetterFixedChannelPool.java 58.04% <0.00%> (+1.72%) 0.00% <0.00%> (ø%)
...ttp/nio/netty/internal/nrs/HttpStreamsHandler.java 64.61% <0.00%> (+3.84%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 704a6c8...b42c327. Read the comment docs.

@dagnir
Copy link
Contributor

dagnir commented May 29, 2020

Hey @Carey-AWS the changelog file is generated from the files in the .changes directory so this change won't persist unfortunately. Can you please update the source file instead?

"type": "feature",
"category": "AWSKendraFrontendService",
"description": "Amazon Kendra is now generally available. As part of general availability, we are launching CHANGELOG.md CODE_OF_CONDUCT.md CONTRIBUTING.md LICENSE.txt NOTICE.txt README.md archetypes aws-sdk-java bom bom-internal build-tools buildspecs bundle codegen codegen-lite codegen-lite-maven-plugin codegen-maven-plugin core docs http-client-spi http-clients pom.xml release-scripts scripts services services-custom test utils Developer edition CHANGELOG.md CODE_OF_CONDUCT.md CONTRIBUTING.md LICENSE.txt NOTICE.txt README.md archetypes aws-sdk-java bom bom-internal build-tools buildspecs bundle codegen codegen-lite codegen-lite-maven-plugin codegen-maven-plugin core docs http-client-spi http-clients pom.xml release-scripts scripts services services-custom test utils Ability to scale your Amazon Kendra index with capacity units CHANGELOG.md CODE_OF_CONDUCT.md CONTRIBUTING.md LICENSE.txt NOTICE.txt README.md archetypes aws-sdk-java bom bom-internal build-tools buildspecs bundle codegen codegen-lite codegen-lite-maven-plugin codegen-maven-plugin core docs http-client-spi http-clients pom.xml release-scripts scripts services services-custom test utils Support for new connectors CHANGELOG.md CODE_OF_CONDUCT.md CONTRIBUTING.md LICENSE.txt NOTICE.txt README.md archetypes aws-sdk-java bom bom-internal build-tools buildspecs bundle codegen codegen-lite codegen-lite-maven-plugin codegen-maven-plugin core docs http-client-spi http-clients pom.xml release-scripts scripts services services-custom test utils Support for new tagging API's CHANGELOG.md CODE_OF_CONDUCT.md CONTRIBUTING.md LICENSE.txt NOTICE.txt README.md archetypes aws-sdk-java bom bom-internal build-tools buildspecs bundle codegen codegen-lite codegen-lite-maven-plugin codegen-maven-plugin core docs http-client-spi http-clients pom.xml release-scripts scripts services services-custom test utils Support for Deleting data source CHANGELOG.md CODE_OF_CONDUCT.md CONTRIBUTING.md LICENSE.txt NOTICE.txt README.md archetypes aws-sdk-java bom bom-internal build-tools buildspecs bundle codegen codegen-lite codegen-lite-maven-plugin codegen-maven-plugin core docs http-client-spi http-clients pom.xml release-scripts scripts services services-custom test utils Metrics for data source sync operations CHANGELOG.md CODE_OF_CONDUCT.md CONTRIBUTING.md LICENSE.txt NOTICE.txt README.md archetypes aws-sdk-java bom bom-internal build-tools buildspecs bundle codegen codegen-lite codegen-lite-maven-plugin codegen-maven-plugin core docs http-client-spi http-clients pom.xml release-scripts scripts services services-custom test utils Metrics for query & storage utilization"

@Carey-AWS Carey-AWS marked this pull request as draft May 29, 2020 16:53
@Carey-AWS Carey-AWS marked this pull request as ready for review May 29, 2020 17:04
@dagnir
Copy link
Contributor

dagnir commented May 29, 2020

LGTM. Can you squash your commits?

@dagnir
Copy link
Contributor

dagnir commented May 29, 2020

Looks like something went wrong during the squashing. You should be able to fix this with

git fetch https://github.com/aws/aws-sdk-java-v2 && git reset --hard FETCH_HEAD && git cherry-pick eefcca4

@Carey-AWS Carey-AWS marked this pull request as draft May 29, 2020 18:58
@Carey-AWS Carey-AWS marked this pull request as ready for review May 29, 2020 19:17
@dagnir dagnir merged commit 3d6d0dc into aws:master May 29, 2020
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

aws-sdk-java-automation added a commit that referenced this pull request Dec 2, 2021
…93507f1da

Pull request: release <- staging/66d16e29-0e27-4871-af9a-b3a93507f1da
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants