Skip to content

DDB Enhanced: Added functional tests to assert that empty strings and… #1780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2020

Conversation

bmaizels
Copy link
Contributor

… bytes are mapped properly

License

  • I confirm that this pull request can be released under the Apache 2 license

@bmaizels bmaizels requested a review from Quanzzzz April 15, 2020 19:04
@bmaizels bmaizels force-pushed the bmaizels/ddbenhanced-empty-strings branch from f2bb541 to acaa55e Compare April 15, 2020 19:06
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-io
Copy link

Codecov Report

Merging #1780 into master will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1780      +/-   ##
============================================
+ Coverage     76.26%   76.39%   +0.12%     
  Complexity      182      182              
============================================
  Files          1073     1073              
  Lines         32260    32329      +69     
  Branches       2513     2536      +23     
============================================
+ Hits          24603    24697      +94     
+ Misses         6409     6389      -20     
+ Partials       1248     1243       -5     
Flag Coverage Δ Complexity Δ
#unittests 76.39% <ø> (+0.12%) 182.00 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
...tomization/CodegenCustomizationProcessorChain.java 81.81% <0.00%> (-8.19%) 0.00% <0.00%> (ø%)
...on/awssdk/protocols/ion/AwsIonProtocolFactory.java 72.72% <0.00%> (-5.06%) 0.00% <0.00%> (ø%)
.../software/amazon/awssdk/core/sync/RequestBody.java 90.00% <0.00%> (-3.11%) 0.00% <0.00%> (ø%)
...ftware/amazon/awssdk/codegen/internal/Jackson.java 59.09% <0.00%> (-2.82%) 0.00% <0.00%> (ø%)
...on/awssdk/codegen/internal/DocumentationUtils.java 75.00% <0.00%> (-2.42%) 0.00% <0.00%> (ø%)
...nhanced/dynamodb/extensions/WriteModification.java 52.00% <0.00%> (-2.17%) 0.00% <0.00%> (ø%)
...ices/s3/internal/presigner/DefaultS3Presigner.java 88.88% <0.00%> (-1.92%) 0.00% <0.00%> (ø%)
...rvices/s3/internal/ConfiguredS3SdkHttpRequest.java 46.15% <0.00%> (-1.85%) 0.00% <0.00%> (ø%)
...retry/DefaultTokenBucketExceptionCostFunction.java 50.00% <0.00%> (-1.73%) 0.00% <0.00%> (ø%)
...ced/dynamodb/model/CreateTableEnhancedRequest.java 63.15% <0.00%> (-1.71%) 0.00% <0.00%> (ø%)
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d2e2e5...acaa55e. Read the comment docs.

@bmaizels bmaizels merged commit 523a0e8 into master Apr 15, 2020
@bmaizels bmaizels deleted the bmaizels/ddbenhanced-empty-strings branch April 15, 2020 19:56
aws-sdk-java-automation added a commit that referenced this pull request Oct 20, 2021
…9701fba25

Pull request: release <- staging/84c00ad8-fde0-4b59-aec5-96d9701fba25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants