Skip to content

Expand http2 connection window upon new stream acquisition #1661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 5, 2020

Conversation

zoewangg
Copy link
Contributor

Description

Expand Http2 connection-level flow control window when a new stream is acquired on that connection so that the connection-level window size is proportional to the number of streams.

Testing

Add new unit test.
Will run integ/stability tests suites.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@codecov-io
Copy link

codecov-io commented Feb 24, 2020

Codecov Report

Merging #1661 into master will increase coverage by 0.04%.
The diff coverage is 87.5%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1661      +/-   ##
============================================
+ Coverage     75.37%   75.41%   +0.04%     
  Complexity     1446     1446              
============================================
  Files          1057     1057              
  Lines         31501    31523      +22     
  Branches       2439     2439              
============================================
+ Hits          23743    23774      +31     
+ Misses         6568     6556      -12     
- Partials       1190     1193       +3
Flag Coverage Δ Complexity Δ
#unittests 75.41% <87.5%> (+0.04%) 1446 <0> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
...k/http/nio/netty/internal/ChannelAttributeKey.java 100% <100%> (ø) 0 <0> (ø) ⬇️
...nio/netty/internal/ChannelPipelineInitializer.java 98.11% <100%> (+0.07%) 0 <0> (ø) ⬇️
...ty/internal/http2/Http2MultiplexedChannelPool.java 76.75% <83.33%> (+1.01%) 0 <0> (ø) ⬇️
...ware/amazon/awssdk/utils/cache/CachedSupplier.java 87.8% <0%> (-2.44%) 0% <0%> (ø)
...ssdk/core/internal/async/FileAsyncRequestBody.java 84.76% <0%> (+0.95%) 0% <0%> (ø) ⬇️
...o/netty/internal/utils/BetterFixedChannelPool.java 64.36% <0%> (+6.32%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2b05d2...3b43da1. Read the comment docs.

@@ -0,0 +1,58 @@
/*
* Copyright 2010-2020 Amazon.com, Inc. or its affiliates. All Rights Reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: believe we remove all the copyright years from the license headers now (#1655)

@zoewangg zoewangg force-pushed the zoewang-expandH2ConnectionWindodw branch from 8f973f5 to 0124df2 Compare February 28, 2020 01:50
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 5, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@zoewangg zoewangg merged commit 3f41cd1 into master Mar 5, 2020
@zoewangg zoewangg deleted the zoewang-expandH2ConnectionWindodw branch March 12, 2020 20:59
aws-sdk-java-automation pushed a commit that referenced this pull request Sep 3, 2021
add japicmp override for aws-core changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants