Skip to content

Dynamodb-enhanced [preview]: small fix to a misnaming of a couple of … #1617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2020

Conversation

bmaizels
Copy link
Contributor

…Attributes made during a recent naming refactor

Description

We changed the way we named attributes and got the naming convention wrong on a couple of them. This fixes that error.

Testing

Unit tests still pass.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

…Attributes made during a recent naming refactor
@bmaizels bmaizels requested a review from spfink January 24, 2020 17:58
@bmaizels bmaizels merged commit 91788e2 into master Jan 24, 2020
@bmaizels bmaizels deleted the bmaizels/ddb-mapper-attribute-naming-fix branch January 24, 2020 18:13
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-io
Copy link

codecov-io commented Jan 24, 2020

Codecov Report

Merging #1617 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1617      +/-   ##
============================================
- Coverage     75.73%   75.73%   -0.01%     
  Complexity      682      682              
============================================
  Files           905      905              
  Lines         28389    28389              
  Branches       2257     2257              
============================================
- Hits          21501    21500       -1     
+ Misses         5870     5869       -1     
- Partials       1018     1020       +2
Flag Coverage Δ Complexity Δ
#unittests 75.73% <ø> (-0.01%) 682 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
...ynamodb/mappingclient/staticmapper/Attributes.java 100% <ø> (ø) 20 <0> (ø) ⬇️
.../http/nio/netty/internal/NettyRequestExecutor.java 68.52% <0%> (-5.59%) 0% <0%> (ø)
...ssdk/core/internal/async/FileAsyncRequestBody.java 83.8% <0%> (-2.86%) 0% <0%> (ø)
...o/netty/internal/utils/BetterFixedChannelPool.java 64.36% <0%> (+6.32%) 0% <0%> (ø) ⬇️
...ine/stages/ApiCallAttemptTimeoutTrackingStage.java 100% <0%> (+6.89%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6aa961...754b766. Read the comment docs.

aws-sdk-java-automation pushed a commit that referenced this pull request Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants