-
Notifications
You must be signed in to change notification settings - Fork 913
Updated README.md to match current design iteration of interface #1616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -134,7 +156,7 @@ key differences: | |||
an asynchronous DynamoDb client from the SDK as well): | |||
```java | |||
AsyncMappedDatabase database = DynamoDbAsyncMappedDatabase.builder() | |||
.dynamoDbAsyncClient(dynamoDbAsyncClient) | |||
.dynamoDbClient(dynamoDbAsyncClient) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if you also want to update the name of the arg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was deliberate to show that we were actually passing in an async client.
.build(); | ||
DynamoDbMappedDatabase.builder() | ||
.dynamoDbClient(dynbamoDbClient) | ||
.extendWith(VersionedRecordExtension.builder().build()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a create method on VersionedRecordExtension if it can be done no-args?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There probably should be, but there isn't, so this is accurate. We plan to integrate that plugin into the core of the mapper anyway so it will be moot soon.
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #1616 +/- ##
============================================
+ Coverage 75.66% 75.69% +0.02%
Complexity 682 682
============================================
Files 905 905
Lines 28337 28389 +52
Branches 2240 2257 +17
============================================
+ Hits 21442 21488 +46
- Misses 5874 5880 +6
Partials 1021 1021
Continue to review full report at Codecov.
|
…aa40ceec7 Pull request: release <- staging/cd4b0dba-d7f1-444f-9e3c-4e6aa40ceec7
The documentation for the dynamodb-enhanced module had fallen out of sync with the changes being made to the interface. This is to correct that and bring it up to date.
License