Skip to content

Updated README.md to match current design iteration of interface #1616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2020

Conversation

bmaizels
Copy link
Contributor

The documentation for the dynamodb-enhanced module had fallen out of sync with the changes being made to the interface. This is to correct that and bring it up to date.

License

  • I confirm that this pull request can be released under the Apache 2 license

@@ -134,7 +156,7 @@ key differences:
an asynchronous DynamoDb client from the SDK as well):
```java
AsyncMappedDatabase database = DynamoDbAsyncMappedDatabase.builder()
.dynamoDbAsyncClient(dynamoDbAsyncClient)
.dynamoDbClient(dynamoDbAsyncClient)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if you also want to update the name of the arg

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was deliberate to show that we were actually passing in an async client.

.build();
DynamoDbMappedDatabase.builder()
.dynamoDbClient(dynbamoDbClient)
.extendWith(VersionedRecordExtension.builder().build())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a create method on VersionedRecordExtension if it can be done no-args?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There probably should be, but there isn't, so this is accurate. We plan to integrate that plugin into the core of the mapper anyway so it will be moot soon.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@bmaizels bmaizels merged commit c6aa961 into master Jan 24, 2020
@bmaizels bmaizels deleted the bmaizels/ddb-mapper-readme-refresh branch January 24, 2020 17:50
@codecov-io
Copy link

Codecov Report

Merging #1616 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1616      +/-   ##
============================================
+ Coverage     75.66%   75.69%   +0.02%     
  Complexity      682      682              
============================================
  Files           905      905              
  Lines         28337    28389      +52     
  Branches       2240     2257      +17     
============================================
+ Hits          21442    21488      +46     
- Misses         5874     5880       +6     
  Partials       1021     1021
Flag Coverage Δ Complexity Δ
#unittests 75.69% <ø> (+0.02%) 682 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
...tomization/CodegenCustomizationProcessorChain.java 81.81% <0%> (-8.19%) 0% <0%> (ø)
...on/awssdk/protocols/ion/AwsIonProtocolFactory.java 72.72% <0%> (-5.06%) 0% <0%> (ø)
.../software/amazon/awssdk/core/sync/RequestBody.java 90% <0%> (-3.11%) 0% <0%> (ø)
...ftware/amazon/awssdk/codegen/internal/Jackson.java 59.09% <0%> (-2.82%) 0% <0%> (ø)
...on/awssdk/codegen/internal/DocumentationUtils.java 75% <0%> (-2.42%) 0% <0%> (ø)
...db/mappingclient/extensions/WriteModification.java 52% <0%> (-2.17%) 5% <0%> (ø)
...rvices/s3/internal/ConfiguredS3SdkHttpRequest.java 46.15% <0%> (-1.85%) 0% <0%> (ø)
...amodb/mappingclient/operations/ConditionCheck.java 41.66% <0%> (-1.2%) 3% <0%> (ø)
...mappingclient/operations/GlobalSecondaryIndex.java 29.03% <0%> (-0.97%) 5% <0%> (ø)
...dynamodb/mappingclient/operations/CreateTable.java 79.66% <0%> (-0.69%) 19% <0%> (ø)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59219bb...af11d4c. Read the comment docs.

aws-sdk-java-automation added a commit that referenced this pull request Aug 18, 2021
…aa40ceec7

Pull request: release <- staging/cd4b0dba-d7f1-444f-9e3c-4e6aa40ceec7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants