Skip to content

Integration tests on S3, kinesis and transcribe #1364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2019
Merged

Integration tests on S3, kinesis and transcribe #1364

merged 1 commit into from
Aug 7, 2019

Conversation

Quanzzzz
Copy link
Contributor

Added integration tests on S3, kinesis and transcribe and fixed a minor logical error in JavaHttpRequestFactory.

Description

Used integration tests on kinesis and transcribe with NettyNioAsyncClient to test the integrated functionality of JavaHttpClientNioAsyncHttpClient. Added a check on fullDuplex of AsyncExecuteRequest to fix the empty request body error. Also more integration tests on S3 with JavaHttpClientNioAsyncHttpClient are added.

Motivation and Context

Before this pr, all the tests are unit tests or mock tests, which could not really simulate the situations of customers using our JavaHttpClient. To make sure that all the non-streaming, streaming and event-streaming requests can be executed correctly, new integration tests are added here in this pull request. And a minor error found during the tests is fixed in this pull request too.

Testing

For S3 service, put, get large object tests and delete object tests are added;
For kinesis service, subscribeToShard and cancelledSubscription integration test are added;
For transcribe service, both of integration tests with audio files and stability tests are added;

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@dagnir
Copy link
Contributor

dagnir commented Jul 26, 2019

Lot of same code here from #1346 since it seems to pick up where that one leaves off, so I won't be reviewing some files again.

@dagnir
Copy link
Contributor

dagnir commented Jul 26, 2019

I don't want to hold this review up for it, but the stability tests, we shouldn't be duplicating the code that's already in https://github.com/aws/aws-sdk-java-v2/tree/master/test/stability-tests. We should just add a dependency on the Java 11 client in the stability-tests package, and modify the tests so that there's a version of them that use the Java 11 client. Let's add that as a backlog item to use the existing stability-tests package to test the Java 11 client.

@Quanzzzz
Copy link
Contributor Author

I don't want to hold this review up for it, but the stability tests, we shouldn't be duplicating the code that's already in https://github.com/aws/aws-sdk-java-v2/tree/master/test/stability-tests. We should just add a dependency on the Java 11 client in the stability-tests package, and modify the tests so that there's a version of them that use the Java 11 client. Let's add that as a backlog item to use the existing stability-tests package to test the Java 11 client.

Okay, I got it, actually I was about to ask about this, it's because these stability tests are added after my work and the project in my branch is still 2.5.62 while the most up to date version is 2.7.8 now, thus I'm afraid if I pull the most up to date version to my repository some other things would change, so I just copied it one by one from the origin repository.

…ement for fullDuplex in JavaHttpRequestFactory
@dagnir dagnir merged commit 518ce26 into aws:java-11-http-client Aug 7, 2019
aws-sdk-java-automation added a commit that referenced this pull request May 5, 2021
…87c5fc191

Pull request: release <- staging/833866f6-1047-4096-bcd8-ee987c5fc191
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants