-
Notifications
You must be signed in to change notification settings - Fork 915
Integration tests on S3, kinesis and transcribe #1364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Lot of same code here from #1346 since it seems to pick up where that one leaves off, so I won't be reviewing some files again. |
I don't want to hold this review up for it, but the stability tests, we shouldn't be duplicating the code that's already in https://github.com/aws/aws-sdk-java-v2/tree/master/test/stability-tests. We should just add a dependency on the Java 11 client in the |
Okay, I got it, actually I was about to ask about this, it's because these stability tests are added after my work and the project in my branch is still 2.5.62 while the most up to date version is 2.7.8 now, thus I'm afraid if I pull the most up to date version to my repository some other things would change, so I just copied it one by one from the origin repository. |
test/stability-tests/src/it/java/software/amazon/awssdk/stability/tests/TestRunner.java
Outdated
Show resolved
Hide resolved
...ware/amazon/awssdk/stability/tests/transcribestreaming/TranscribeStreamingStabilityTest.java
Outdated
Show resolved
Hide resolved
.../src/test/java/software/amazon/awssdk/http/nio/java/internal/JavaHttpRequestFactoryTest.java
Show resolved
Hide resolved
...test/java/software/amazon/awssdk/http/nio/java/internal/SubscribeToShardIntegrationTest.java
Show resolved
Hide resolved
...nio-client/src/test/java/software/amazon/awssdk/http/nio/java/internal/TestSubscription.java
Outdated
Show resolved
Hide resolved
...client/src/test/java/software/amazon/awssdk/http/nio/java/internal/TestResponseHandlers.java
Outdated
Show resolved
Hide resolved
...core/src/main/java/software/amazon/awssdk/core/internal/async/ByteArrayAsyncRequestBody.java
Outdated
Show resolved
Hide resolved
...ient/src/main/java/software/amazon/awssdk/http/nio/java/internal/JavaHttpRequestFactory.java
Outdated
Show resolved
Hide resolved
...test/java/software/amazon/awssdk/http/nio/java/internal/S3JavaHttpClientIntegrationTest.java
Outdated
Show resolved
Hide resolved
…ement for fullDuplex in JavaHttpRequestFactory
…87c5fc191 Pull request: release <- staging/833866f6-1047-4096-bcd8-ee987c5fc191
Added integration tests on S3, kinesis and transcribe and fixed a minor logical error in JavaHttpRequestFactory.
Description
Used integration tests on kinesis and transcribe with NettyNioAsyncClient to test the integrated functionality of JavaHttpClientNioAsyncHttpClient. Added a check on fullDuplex of AsyncExecuteRequest to fix the empty request body error. Also more integration tests on S3 with JavaHttpClientNioAsyncHttpClient are added.
Motivation and Context
Before this pr, all the tests are unit tests or mock tests, which could not really simulate the situations of customers using our JavaHttpClient. To make sure that all the non-streaming, streaming and event-streaming requests can be executed correctly, new integration tests are added here in this pull request. And a minor error found during the tests is fixed in this pull request too.
Testing
For S3 service, put, get large object tests and delete object tests are added;
For kinesis service, subscribeToShard and cancelledSubscription integration test are added;
For transcribe service, both of integration tests with audio files and stability tests are added;
Screenshots (if appropriate)
Types of changes
Checklist
mvn install
succeedsLicense