Skip to content

Bugfix #1145 #1146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2019
Merged

Bugfix #1145 #1146

merged 1 commit into from
Mar 19, 2019

Conversation

GuillermoBlasco
Copy link
Contributor

Fixed param validation. See issue #1145.

In line 80 of SdkBytes.java there is a param validation that does not correspond to the actual param to validate. As of seen in version 2.5.10

Fixed param validation. See issue aws#1145.
@varunnvs92
Copy link
Contributor

Changes lgtm. Please rebase with master branch. I will merge after successful code build.

@codecov-io
Copy link

Codecov Report

Merging #1146 into master will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1146      +/-   ##
============================================
+ Coverage      58.8%   58.81%   +0.01%     
  Complexity     4563     4563              
============================================
  Files           742      742              
  Lines         22892    22892              
  Branches       1706     1706              
============================================
+ Hits          13462    13465       +3     
+ Misses         8736     8735       -1     
+ Partials        694      692       -2
Impacted Files Coverage Δ Complexity Δ
...ain/java/software/amazon/awssdk/core/SdkBytes.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...on/awssdk/services/kinesis/KinesisRetryPolicy.java 85.71% <0%> (ø) 2% <0%> (-1%) ⬇️
...nio/netty/internal/OldConnectionReaperHandler.java 90.9% <0%> (+9.09%) 15% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0188101...6f7ede9. Read the comment docs.

@varunnvs92 varunnvs92 merged commit 07fdff0 into aws:master Mar 19, 2019
aws-sdk-java-automation added a commit that referenced this pull request Jan 12, 2021
…551f456d9

Pull request: release <- staging/ba71cc4a-dd43-4e37-8373-ecf551f456d9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants