Fix async request cancellation #1112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagnir
force-pushed
the
async-request-cancel-fix
branch
from
80ffda9 to
2bfe7c7
Compare
varunnvs92
reviewed
Mar 6, 2019
| CompletableFuture<AllTypesResponse> responseFuture = client.allTypes(r -> {}); | ||
| responseFuture.cancel(true); | ||
| Thread.sleep(500); |
There was a problem hiding this comment.
Is 500 sufficient or will this cause transient failures?
There was a problem hiding this comment.
Not sure, I'm just trying to figure out if this will fix the test fails in Travis ATM. I'll probably increase to 1s if it works
dagnir
force-pushed
the
async-request-cancel-fix
branch
2 times, most recently
from
266f50e to
d176350
Compare
Codecov Report
@@ Coverage Diff @@
## master #1112 +/- ##
============================================
+ Coverage 58.49% 58.52% +0.03%
- Complexity 4494 4507 +13
============================================
Files 737 738 +1
Lines 22663 22715 +52
Branches 1690 1698 +8
============================================
+ Hits 13256 13295 +39
- Misses 8718 8729 +11
- Partials 689 691 +2
Continue to review full report at Codecov.
|
varunnvs92
approved these changes
Mar 7, 2019
- Correctly pass along the cancelled signal down to the async client if the future returned for an async operation is cancelled. - Don't wait for acquire to finish to cancel; instead fail the promise if not complete yet CancellableAcquireChannelPool added to take care of closing and releasing a cancelled acquire.
dagnir
force-pushed
the
async-request-cancel-fix
branch
from
d176350 to
84714ac
Compare
aws-sdk-java-automation
pushed a commit
that referenced
this pull request
Dec 17, 2020
…3363cff76 Pull request: release <- staging/0e6dd94a-3bd9-40aa-a91e-77f3363cff76
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Correctly pass along the cancelled signal down to the async client if the
future returned for an async operation is cancelled.
Don't wait for acquire to finish to cancel; instead fail the promise if not
complete yet
CancellableAcquireChannelPool added to take care of closing and releasing a
cancelled acquire.
Motivation and Context
Bug fix.
Testing
Added/updated tests in
codegen,codegen-generated-classes-test, andnetty-nio-client.Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsLicense