Fix HeaderUnmarshaller to compare headers ignoring cases #1105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1105 +/- ##
============================================
- Coverage 58.63% 58.62% -0.02%
- Complexity 4528 4531 +3
============================================
Files 738 738
Lines 22749 22751 +2
Branches 1699 1699
============================================
- Hits 13339 13337 -2
- Misses 8720 8722 +2
- Partials 690 692 +2
Continue to review full report at Codecov.
|
spfink
approved these changes
Mar 1, 2019
| s3.headObject(b -> b.bucket(BUCKET_NAME).key(KEY).overrideConfiguration(r -> r.putHeader("x-amz-metadata-test", | ||
| "test"))); | ||
|
|
||
| //assertThat(response.metadata()) |
There was a problem hiding this comment.
Yes, this test is actually unnecessary and I forgot to remove it.
zoewangg
force-pushed
the
zoewang-fixHeaderUnmarshalling
branch
from
3e05610 to
3738c81
Compare
zoewangg
force-pushed
the
zoewang-fixHeaderUnmarshalling
branch
from
3738c81 to
4d4176f
Compare
|
Added protocol tests. |
aws-sdk-java-automation
added a commit
that referenced
this pull request
Dec 16, 2020
…9576efaa1 Pull request: release <- staging/051b064e-d2bd-4420-bf1f-9509576efaa1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix xml
HeaderUnmarshaller#MAPto compare headers ignoring cases. Checked Json HeaderUnmarshaller and it doesn't have MAP type.Motivation and Context
Fixes #1091
Testing
Added unit tests and integ tests
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsLicense