Runtime HTTP client resolution in OSGi

[dagnir]

Today, HTTP client resolution happens at runtime using Java's ServiceLoader class. This works fine in most cases, but not in OSGi: https://blog.osgi.org/2013/02/javautilserviceloader-in-osgi.html

We should create an OSGi-aware implementation of SdkHttpServiceProvider, and make current and future implementations of the HTTP client SPI loadable in an OSGi environment.

[varunnvs92]

Based on this post, I made the changes to manifest files of sdk-core, http client implementations. See aa65c67
I tried to test it in Apache felix environment but I keep getting failures to resolve a lot of missing dependencies. At the end, I had issues with files from sun and they are not available as a bundle. For now, Pushing the changes to varunkn/OsgiCompatibility branch. I ask any osgi experts to install this branch in a osgi env and make a successful service call to verify it works.

[dagnir]

Looks like the Netty Reactive Streams packages aren't available as OSGi bundles: playframework/netty-reactive-streams#5

[sarod]

This is still broken in latest SDK version 2.5.17.

The fix made in commit 2614631 has apparently been removed as part of b5acc52.

@dagnir was this forgotten or is it on purpose?

[dagnir]

@sarod Thanks for pinging this. I'm going to go ahead and reopen this as the fix made to Netty as part of #1391 should now unblock the Netty client.

We're still tracking OSGi compatibility for the SDK as a whole in #59.