AWS v2 SDK not working without https proxy specified

[xiangfei8]

Describe the issue

configure proxy pathway as what is inside the IF statement below is working fine.
if (isProxyDefined) {
httpClient = ApacheHttpClient.builder()
.proxyConfiguration(ProxyConfiguration.builder()
.useSystemPropertyValues(false)
.endpoint(URI.create((new StringBuffer().append("http://")
.append(envHttpsProxyHost)
.append(":")
.append(envHttpsProxyPort)).toString()))
.build())
.build();
} else {
httpClient = ApacheHttpClient.builder()
.build();
}

I recently try to deploy the software to an environment without proxy needed, and I confirm it is getting inside the ELSE statement. But I am consistently getting the following stack trace. Why is the sdk giving a "java.lang.NumberFormatException" trying to look for a port that is not defined anyway? Is there another API call I should be using instead for a no proxy environment?

            java.lang.NumberFormatException: For input string: ""
                at java.base/java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)
                at java.base/java.lang.Integer.parseInt(Integer.java:662)
                at java.base/java.lang.Integer.parseInt(Integer.java:770)
                at java.base/java.util.Optional.map(Optional.java:265)
                at software.amazon.awssdk.http.apache.ProxyConfiguration.resolvePort(ProxyConfiguration.java:199)
                at software.amazon.awssdk.http.apache.ProxyConfiguration.<init>(ProxyConfiguration.java:66)
                at software.amazon.awssdk.http.apache.ProxyConfiguration.<init>(ProxyConfiguration.java:38)
                at software.amazon.awssdk.http.apache.ProxyConfiguration$DefaultClientProxyConfigurationBuilder.build(ProxyConfiguration.java:407)
                at software.amazon.awssdk.http.apache.ProxyConfiguration$DefaultClientProxyConfigurationBuilder.build(ProxyConfiguration.java:298)
                at software.amazon.awssdk.http.apache.ApacheHttpClient$DefaultBuilder.<init>(ApacheHttpClient.java:427)
                at software.amazon.awssdk.http.apache.ApacheHttpClient$DefaultBuilder.<init>(ApacheHttpClient.java:425)
                at software.amazon.awssdk.http.apache.ApacheHttpClient.builder(ApacheHttpClient.java:133)
                at 

As you can see, this issue is coming from software.amazon.awssdk.http.apache.ProxyConfiguration.

Steps to Reproduce

Make a STS call in an environment that have no proxy set up.

StsClient getStsClient(AwsBasicCredentials awsCreds) {
    return StsClient.builder()
                    .credentialsProvider(StaticCredentialsProvider.create(awsCreds))
                    .region(Region.of(awsS3BucketRegion))
                    .build();
}

OR

StsClient getStsClient(AwsBasicCredentials awsCreds) {
    return StsClient.builder()
                    .credentialsProvider(StaticCredentialsProvider.create(awsCreds))
                    .region(Region.of(awsS3BucketRegion))
                    .httpClient(ApacheHttpClient.builder().build())
                    .build();
}

Current behavior

get runtime exception: java.lang.NumberFormatException: For input string: ""
detail stack is in the description

AWS Java SDK version used

2.14.18, I also tried 2.17.115

JDK version used

openjdk-11-5-5

Operating System and version

debian:10.3-slim

[debora-ito]

Hi @xiangfei8 this is indeed a confusing issue, I think ProxyConfguration is only called if they are declared in the client builder.

All clients are immutable after creation. Is it possible your code is running into a situation where it's unintentionally trying to change a client built with a proxy config?

[xiangfei8]

@debora-ito - I only create the ApacheHttpClient once in @PostConstruct in my code
httpClient = ApacheHttpClient.builder()
.build();

And I got this exception from that spot.

[debora-ito]

if (isProxyDefined) {
httpClient = ApacheHttpClient.builder()
.proxyConfiguration(ProxyConfiguration.builder()
.useSystemPropertyValues(false)
.endpoint(URI.create((new StringBuffer().append("http://")
.append(envHttpsProxyHost)
.append(":")
.append(envHttpsProxyPort)).toString()))
.build())
.build();
} else {
httpClient = ApacheHttpClient.builder()
.build();
}

In the description you showed this snippet, how is this used? Can you show a code sample?

[xiangfei8]

1. @PostConstruct
   void initSetup() {
   initProxy();

2. the above snippet of building the httpClient is inside the initProxy() method

3. Then the httpClient is used by various method call inside the bean, for example,
   S3Client s3 = S3Client.builder()
   .credentialsProvider(StaticCredentialsProvider.create(awsCreds))
   .region(Region.of(awsS3BucketRegion))
   .httpClient(httpClient())
   .build()) {

OR

StsClient.builder()
.credentialsProvider(StaticCredentialsProvider.create(awsCreds))
.region(Region.of(awsS3BucketRegion))
.httpClient(httpClient())
.build();

[debora-ito]

If you remove the logic from initSetup() and put it on the client builders, do you still see the error?

My guess is the httpClient is being built once with ProxyConfiguration, and being reused later on in environments that may not have proxy configured. You should check how the httpclient is being created initially when the error is thrown, taking the @PostConstruct and the HttpClient immutability into consideration.

[xiangfei8]

If you remove the logic from initSetup() and put it on the client builders, do you still see the error? yes
My guess is the httpClient is being built once with ProxyConfiguration, and being reused later on in environments that may not have proxy configured. - no the case, the httpClient is created and used in the same container