Skip to content

Fix copy and add missing help panels #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 13, 2023
Merged

Fix copy and add missing help panels #172

merged 2 commits into from
Apr 13, 2023

Conversation

tmscarla
Copy link
Contributor

Description

  • Fixed copywriting following tech writer instructions
  • Added missing help panels in form fields
  • Aligned e2e tests

How Has This Been Tested?

  • Unit tests
  • e2e tests
  • Manually inspected affected pages in local environment

PR Quality Checklist

  • I added tests to new or existing code
  • I removed hardcoded strings and used react-i18next library (useTranslation hook and/or Trans component), see an example here
  • I made sure no sensitive info gets logged at any time in the codebase (see here) (e.g. no user info or details, no stacktraces, etc.)
  • I checked that infrastructure/update_infrastructure.sh runs without any error
  • I checked that npm run build builds without any error
  • I checked that clusters are listed correctly
  • I checked that a new cluster can be created (config is produced and dry run passes)
  • I checked that login and logout work as expected

In order to increase the likelihood of your contribution being accepted, please make sure you have read both the Contributing Guidelines and the Project Guidelines

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@tmscarla tmscarla requested a review from mtfranchetto April 13, 2023 13:04
@tmscarla tmscarla force-pushed the tsscarla/fix-copy branch from ee73267 to c9f26b9 Compare April 13, 2023 13:09
@tmscarla tmscarla force-pushed the tsscarla/fix-copy branch from 78aa724 to 219c87b Compare April 13, 2023 14:06
@tmscarla tmscarla merged commit 12f936a into main Apr 13, 2023
@tmscarla tmscarla deleted the tsscarla/fix-copy branch April 13, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants