Adding default constructor for S3Event for easier deserialization #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for easier deserialization
galbash
force-pushed
the
s3-event-default-constructor
branch
from
fc97201 to
4d7cc9e
Compare
maxday
pushed a commit
that referenced
this pull request
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: No issue opened.
Description of changes: Adding a default constructor to the S3Event. The reason for doing this is that it already has another constructor (which gets a list of records), so when working with Jackson we might encounter some issues when trying to deserialize data into this type.
The reason for adding the empty constructor is similar to the one explained here: https://docs.aws.amazon.com/lambda/latest/dg/java-handler-io-type-pojo.html under "note". Also, every other event class has a default constructor.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.