Skip to content

Integrating Custom Properties to ActiveMQEvent #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lohithpc1
Copy link

Issue #, if available:
Custom Properties Set by the customer are not being propagated to target function, as we don't have a properties field in here.

Description of changes:
Added properties field and also a unit test to see if we are getting right fields.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lohithpc1 lohithpc1 requested review from smirnoal and removed request for msailes and andclt November 11, 2022 18:25
@smirnoal smirnoal requested review from andclt and msailes November 11, 2022 18:32
Copy link
Collaborator

@msailes msailes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andclt
Copy link
Contributor

andclt commented Nov 11, 2022

Thanks, LGTM

@andclt andclt merged commit 139993f into aws:events-v4-serialization-v2 Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants