Skip to content

Adding the CodePipelineEvent #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 11, 2022

Conversation

msailes
Copy link
Collaborator

@msailes msailes commented Aug 10, 2022

Issue #, if available:
#16

Description of changes:
Adding the CodePipelineEvent

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@msailes msailes requested review from andclt and smirnoal August 11, 2022 08:03
@JsonProperty("CodePipeline.job")
private Job codePipelineJob;

@lombok.Data
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fully qualified because there is a member variable named data

private Location location;

@JsonInclude
public String getRevision() {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added specific getter and setter for this attribute because Jackson was not including the attribute when it was attached to the parameter.

@andclt suspected it might be a problem with Lombok and Jackson not working together.

@smirnoal smirnoal merged commit 88d3947 into aws:events-v4-serialization-v2 Aug 11, 2022
@msailes msailes deleted the codepipeline branch June 13, 2023 09:09
@cristianocca
Copy link

Will this ever make it to the v3 branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants