-
Notifications
You must be signed in to change notification settings - Fork 86
chore: performance tests for ESDK-python #680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
performance_tests/src/aws_encryption_sdk_performance_tests/keyrings/aws_kms_keyring.py
Outdated
Show resolved
Hide resolved
performance_tests/src/aws_encryption_sdk_performance_tests/master_key_providers/pylintrc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's your plan for running this in CI?
I wonder if you can put this in GHA...
performance_tests/src/aws_encryption_sdk_performance_tests/utils/util.py
Outdated
Show resolved
Hide resolved
Currently for CI, I'm thinking of putting this in CodeBuild for consistency with other tests using MPL. |
performance_tests/src/aws_encryption_sdk_performance_tests/__init__.py
Outdated
Show resolved
Hide resolved
performance_tests/src/aws_encryption_sdk_performance_tests/keyrings/aws_kms_keyring.py
Outdated
Show resolved
Hide resolved
performance_tests/src/aws_encryption_sdk_performance_tests/keyrings/aws_kms_keyring.py
Outdated
Show resolved
Hide resolved
return click.testing.CliRunner() | ||
|
||
|
||
def test_create(runner): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[curious] how much work would it be to print out the summary statistics to the codebuild logs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would be calling the consolidate results script.
It would basically mean running the consolidate_results.py script from the test python files for each of the tests.
Issue #, if available:
Description of changes:
Performance tests for ESDK-python for comparison between keyrings and master key providers based on execution time and memory used.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: