Skip to content

chore: Pin dependencies for linters #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 31, 2022

Conversation

lavaleri
Copy link
Contributor

Pin dependencies for linters to minimize broken builds on old branch

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

@lavaleri lavaleri requested a review from a team as a code owner December 21, 2021 22:13
@@ -0,0 +1,14 @@
bandit==1.7.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nitpick, but can we consistently use _ or - for file and directory names?

Copy link
Contributor

@texastony texastony Jan 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this repo, there is a mostly consistent policy that directories use _ and files use -.

I do not see the value in this policy.
I do not know how this came to be.
I am not going to suggest we enforce it in any way.
But since this already meets the policy, I suggest we leave it as is.

@@ -0,0 +1,14 @@
bandit==1.7.0
Copy link
Contributor

@texastony texastony Jan 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this repo, there is a mostly consistent policy that directories use _ and files use -.

I do not see the value in this policy.
I do not know how this came to be.
I am not going to suggest we enforce it in any way.
But since this already meets the policy, I suggest we leave it as is.

@texastony texastony requested a review from smswz January 28, 2022 20:11
@texastony texastony merged commit 80c80d9 into aws:mainline-2.x Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants