Skip to content

refactor: Remove keyring trace #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 13, 2020

Conversation

MatthewBennington
Copy link
Contributor

@MatthewBennington MatthewBennington commented Aug 10, 2020

Issue #, if available: resolves #272

Description of changes:

Note: Some tests were removed, or had some assert statements removed. Coverage is unchanged.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

@MatthewBennington MatthewBennington self-assigned this Aug 10, 2020
@mattsb42-aws
Copy link
Member

Some minor formatting stuff. Otherwise good. :)

MatthewBennington and others added 5 commits August 13, 2020 08:43
Co-authored-by: Matt Bullock <bullocm@amazon.com>
Co-authored-by: Matt Bullock <bullocm@amazon.com>
Co-authored-by: Matt Bullock <bullocm@amazon.com>
Co-authored-by: Matt Bullock <bullocm@amazon.com>
Co-authored-by: Matt Bullock <bullocm@amazon.com>
@MatthewBennington MatthewBennington merged commit 0d21816 into aws:keyring Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants