Skip to content

docs: add links to custom AWS KMS client configuration examples in examples readme #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 20, 2020
Merged

Conversation

mattsb42-aws
Copy link
Member

Description of changes:

In going through to enumerate the examples for awslabs/aws-encryption-sdk-specification#103, I realized that the client supplier examples were not linked.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

@mattsb42-aws mattsb42-aws added this to the keyrings milestone May 12, 2020
@mattsb42-aws mattsb42-aws requested review from ajorg-aws and seebees and removed request for ajorg-aws May 12, 2020 23:14
@mattsb42-aws mattsb42-aws changed the title docs: add links to client supplier examples in examples readme docs: add links to custom AWS KMS client configuration examples in examples readme May 12, 2020
Copy link

@acioc acioc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming those referenced files are already committed. Looks good!

@mattsb42-aws mattsb42-aws merged commit 5628ede into aws:master May 20, 2020
@mattsb42-aws mattsb42-aws deleted the links branch May 20, 2020 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants