chore: merge master into keyring #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added a check for max_age being greater than 0 * Fixed flake8 by adding missing pydocstyle dependency * Added the dependency to decrypt_oracle as well * Added test for max_age<=0 ValueError * Updated test for max_age<=0.0 ValueError * Added negative test case
Update PR template
…ured (#179) * Fixed KMS master key provider tests for users who have their default AWS region configured * created fixture for botocore session with no region set * add auto-used fixture in KMS master key provider unit tests to test against both with and without default region
Co-Authored-By: Matt Bullock <bullocm@amazon.com>
…yption-sdk-python into a2b1c1-example
Example for using one KMS CMK with an unsigned algorithm
* [issue-190] Creation of regional clients modifies default botocore session's region
1.4.1 release
* pylint max-attributes appears to be ratcheted down recently * remove unnecessary comprehensions * whitelist some pylint use-constant-test false-positives * reorganize backwards compatibility test requirements definitions attrs==19.2.0 removed a deprecated feature that aws-encryption-sdk==1.3.3 depended on. This reorganization lets us define specific requirements bounds for old versions of aws-encryption-sdk that will probably continue to be necessary as these old versions age. * remove unnecessary comprehensions * add newlines to the end of all requirements files
…tibility issues with pydocstyle 4.x (#203)
* chore: Update security issue notification This should be at the top of the contributing page, and should be linked at the top of the readme. * Update README.rst Co-Authored-By: Matt Bullock <bullocm@amazon.com> * docs: update CONTRIBUTING.md Co-Authored-By: June Blender <juneb@users.noreply.github.com> Co-authored-by: Matt Bullock <bullocm@amazon.com> Co-authored-by: June Blender <juneb@users.noreply.github.com>
this example is replaced by the onestep_unsigned example
WesleyRosenblum
approved these changes
Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
In preparation for the merge of
keyringintomaster.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: