Skip to content

Convert all tests to pytest #99

Closed
Closed
@mattsb42-aws

Description

@mattsb42-aws

A lot of the original test suite was written in unittest. Let's get all of that moved over to pytest.

Initially, this should be converting unittest.TestCase classes to pytest classes similar to what was done in #98. We can pull those methods out to stand-alone functions later if we decide we want to, but leaving them in classes will make the diffs most simpler.

I would also like to opportunistically remove some of the over-zealous mocking present in these classes where we can.

Test modules to convert:

Due to the changes that will need to happen, anyone looking at this please follow the following guidelines:

  1. Convert from unittest classes to classes using pytest first. We can change to functions later if desired, but converting the classes directly will minimize the changes in each test file.
  2. One test file per PR. This will minimize the amount of changes that need to be reviewed and speed up the review process.
  3. Run tox -re autoformat before committing to apply our formatting rules.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions