chore: Mark 1.x as End-of-Support #994
Conversation
ran: ``` npx prettier --config .prettierrc.js --write -- modules/**/src/*.ts modules/**/test/**/*.ts ```
|
Apparently CodeBuild does not support NodeJS 12? How can that be? |
|
ahh i see why it fails, on master we override the codebuild the default codebuild spec to use image image: |
|
|
|
@texastony, let's talk about this tomorrow to get consensus from everyone if this is the right approach |
|
CB NodeJS10 failed starting Karma, though its possible Karma did run but not log anything: CB NodeJS12 failed while running Karma tests: So NodeJS12 had one timeout and one real failure... |
|
On my local: Ok... Karma is running out of memory on my local, |
|
On my local: NodeJs12 Karma failure is probably transitive. So what to do with NodeJS10... |
|
Our CB tells node to use 4GB, but our CB compute only has 3GB. Let's see if I can get it pass on my local with 4GB, |
|
On my local, with Everything passed. Determining the exact cause of We know that all tests pass for NodeJS12. We are happy enough with that. |
|
With b8e1c6a, I left NodeJS10 testing, but skipped |
|
Fudge, on b8e1c6a, NodeJS12 failed Interesting logs for b8e1c6a NodeJS12: So everything is grand, and we launched Karam and Chrome, but then: The above repeats two more times until Which get us And our failed build. So the Karma test runner cannot connect to the Chrome browser it created... |
|
My local is on 12.22.10, while CB is on 12.22.12. On my local: All tests pass... could it be that CB is actually running out of RAM? For the record, NodeJS10 passed; which means integration tests for Browser (and Node) are passing, even if the Browser's unit tests are failing to start. |
|
On d4dd3b1, NodeJS12 failed a |
|
NodeJS10 failed for f293d5a b/c 10 is not available on 5.0. But NodeJS12 passed |
| # Generate new version and CHANGELOG entry and push it | ||
| - npx lerna version --conventional-commits --git-remote origin --yes ${VERSION_BUMP:+$VERSION_BUMP --force-publish} | ||
| # Log the commit for posterity | ||
| - git log -n 1 |
There was a problem hiding this comment.
were you able to test this on your local to see if it worked?
There was a problem hiding this comment.
testing, on my local:
nvm use 12; npm run clean; rm -rf node_modules; npm ci --unsafe-perm;
git checkout -b 1.x-test-learna-version
git push --set-upstream public_tony 1.x-test-learna-version
npx lerna version --conventional-commits --git-remote origin --yes ${VERSION_BUMP:+$VERSION_BUMP --force-publish}
<generate GitHub auth token>
<export GitHub auth token as GITHUB_PAT>
gh auth login
npx lerna version --conventional-commits --git-remote public_tony --yes ${"":+"" --force-publish}
Results are here texastony@03424c5
Issue #, if available: Mark 1.x as End-of-Support
Description of changes:
Update Support Policy, marking:
Back-ported CodeBuild NPM Publish automation.
However, the back port is not as useful as the Master version.
It does not pull the artifacts from NPM and test them after publishing.
To do that, I would need to back-port much of this PR, which deprecates Node10.
Squash Commit Message:
chore: warn 1.x is End-of-SupportBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: