Deprecate node 8 and 10 #645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karma, Webpack, and Verdaccio all had breaking changes across major versions. Also Typescript, ESLint, and Prettier has major changes. BREAKING CHANGE: This commit upgrades dependencies to no longer support Node 8 and 10.
Upgrade several testing dependencies. The largest change was removing support for the way we were doing code coverage. Compile source and tests in one go.
This is also related to nom 7. Which changes the way `npx` works.
The way that fields were emitted by Typescript changed. `declare` will make Typescript not emit the field. This means that `readOnlyProperty` will correctly add the filed. See: https://www.typescriptlang.org/tsconfig#useDefineForClassFields
BREAKING CHANGE: Removing CI coverage for Node 10
Now that TS is building both the tests and source.
Comment on lines
+126
to
+138
| crv?: string | ||
| d?: string | ||
| dp?: string | ||
| dq?: string | ||
| e?: string | ||
| k?: string | ||
| kty?: string | ||
| n?: string | ||
| p?: string | ||
| q?: string | ||
| qi?: string | ||
| x?: string | ||
| y?: string |
There was a problem hiding this comment.
Can we add comments explaining these? The variable names are opaque to me.
There was a problem hiding this comment.
This is a copy of the JsonWebKey type. They are not my invention.
/* These are copies of the v12 Node.js types.
- I copied them here to avoid exporting v12 types
- and forcing consumers to install/use v12 in their projects.
is the relevant comment.
It is no longer 12, and now 14 as well as some DOM types.
farleyb-amazon
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #644
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: