fix!: Remove Keyring Trace #402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolves: aws#351 As outlined the intention of the keyring trace is better satisfied by constructing correct keyrings and CMMs. BREAKING CHANGE: - Remove trace from all cryptographic materials. - Remove KeyringTrace exports
alex-chew
requested changes
Aug 5, 2020
| @@ -334,18 +229,15 @@ describe('decorateEncryptionMaterial', () => { | |||
| ) | |||
| const test: any = decorateEncryptionMaterial({ | |||
| suite, | |||
| keyringTrace: [], | |||
|
|
|||
| @@ -374,15 +265,10 @@ describe('decorateEncryptionMaterial', () => { | |||
| }) | |||
| const test: any = decorateEncryptionMaterial({ | |||
| suite, | |||
| keyringTrace: [], | |||
|
|
|||
modules/material-management/test/cryptographic_material.test.ts
Outdated
Show resolved
Hide resolved
modules/material-management/test/cryptographic_material.test.ts
Outdated
Show resolved
Hide resolved
modules/material-management/test/cryptographic_material.test.ts
Outdated
Show resolved
Hide resolved
modules/material-management/test/cryptographic_material.test.ts
Outdated
Show resolved
Hide resolved
modules/material-management/test/cryptographic_material.test.ts
Outdated
Show resolved
Hide resolved
modules/material-management/test/cryptographic_material.test.ts
Outdated
Show resolved
Hide resolved
modules/material-management/test/cryptographic_material.test.ts
Outdated
Show resolved
Hide resolved
modules/material-management/test/cryptographic_material.test.ts
Outdated
Show resolved
Hide resolved
alex-chew
requested changes
Aug 5, 2020
alex-chew
previously approved these changes
Aug 6, 2020
seebees
added a commit
that referenced
this pull request
Oct 9, 2020
resolves: #351 As outlined the intention of the keyring trace is better satisfied by constructing correct keyrings and CMMs. BREAKING CHANGE: - Remove trace from all cryptographic materials. - Remove KeyringTrace exports Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #351
As outlined the intention of
the keyring trace
is better satisfied
by constructing correct keyrings and CMMs.
BREAKING CHANGE:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: