Skip to content

chore: add GitHub Actions workflow check for copyright header and fix missing copyright headers #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2020

Conversation

mattsb42-aws
Copy link
Member

@mattsb42-aws mattsb42-aws commented May 18, 2020

Description of changes:

This adds a GitHub Actions workflow for static analysis checks. Right now the only one is not-grep[1], which we're using to check for copyright headers in all source code files.

Also included are fixes for some files that we missed previously.

Run of workflow visible here[2].

[1] https://github.com/marketplace/actions/not-grep
[2] https://github.com/mattsb42-aws/aws-encryption-sdk-javascript/runs/686987225?check_suite_focus=true

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

@mattsb42-aws mattsb42-aws requested a review from a team May 18, 2020 22:08
@mattsb42-aws mattsb42-aws changed the title Add GitHub Actions workflow check for copyright header chore: add GitHub Actions workflow check for copyright header May 18, 2020
@mattsb42-aws mattsb42-aws changed the title chore: add GitHub Actions workflow check for copyright header chore: add GitHub Actions workflow check for copyright header and fix missing copyright headers May 19, 2020
@mattsb42-aws mattsb42-aws merged commit 406d053 into aws:master May 19, 2020
@mattsb42-aws mattsb42-aws deleted the copyright branch May 19, 2020 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants