Skip to content

doc: Update Readme #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 26, 2019
Merged

doc: Update Readme #218

merged 2 commits into from
Sep 26, 2019

Conversation

seebees
Copy link
Contributor

@seebees seebees commented Sep 26, 2019

Aline the documentation with the implemented cli interface.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

Aline the documentation with the implemented cli interface.
@seebees seebees requested review from juneb and a team September 26, 2019 19:29
It's designed to facilitate testing for the set of test vectors of the AWS Encryption SDK.
The test vectors can be found [here] (https://github.com/awslabs/aws-encryption-sdk-test-vectors/tree/a28851a188163e45b8cbf94c1d5a1e67e9622aa8).
This repository is for compatibility tests with the other versions of the AWS Encryption SDKs.
It's purpose is to facilitate testing the set of test vectors the AWS Encryption SDK.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: Its purpose is to test the known-good static test vectors of the AWS Encryption SDK.

This module includes compatibility tests with the other versions of the AWS Encryption SDK.
It's designed to facilitate testing for the set of test vectors of the AWS Encryption SDK.
The test vectors can be found [here] (https://github.com/awslabs/aws-encryption-sdk-test-vectors/tree/a28851a188163e45b8cbf94c1d5a1e67e9622aa8).
This repository is for compatibility tests with the other versions of the AWS Encryption SDKs.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a separate repository or is it a separate folder for the browser tests?

Copy link
Contributor

@ajw-aws ajw-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. English is much improved.

@ajw-aws ajw-aws merged commit ddb0723 into aws:master Sep 26, 2019
@seebees seebees deleted the update_integration_readme branch September 26, 2019 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants