Skip to content

fix: Better timingSafeEqual definition #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 6, 2019
Merged

fix: Better timingSafeEqual definition #203

merged 4 commits into from
Sep 6, 2019

Conversation

seebees
Copy link
Contributor

@seebees seebees commented Aug 28, 2019

Better to use const where possible.
The function is private, this way it is not possible to redefine.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

@seebees seebees requested a review from a team August 28, 2019 04:34
agray256
agray256 approved these changes Sep 6, 2019
View reviewed changes
Copy link

@agray256 agray256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree const function is better choice here (for the immutability aspect).

@seebees seebees merged commit 12d1661 into aws:master Sep 6, 2019
@seebees seebees deleted the timeing_safe_equal_iife branch September 6, 2019 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agray256 agray256 agray256 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seebees @agray256