fix: BYTES_PER_KEY value #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seebees
force-pushed
the
max_bytes_per_key
branch
from
699786e to
f5e3805
Compare
Maximum number of bytes which are allowed to be encrypted under a single data key The _real_ maximum is 2 ** 63 - 1, However Javascript can only perform safe operations on values up to Number.MAX_SAFE_INTEGER === 9007199254740991 === 2 ** 53 - 1. e.g Number.MAX_SAFE_INTEGER + 1 === Number.MAX_SAFE_INTEGER + 2 => true Number.MAX_SAFE_INTEGER + 1 > Number.MAX_SAFE_INTEGER + 2 => false Number.MAX_SAFE_INTEGER + 1 < Number.MAX_SAFE_INTEGER + 2 => false This means that after 2 ** 53 - 1 the process of accumulating a byte count will never yield an accurate comparison and so, never halt. The choice here to use 2 ** 53 - 1 instead of Number.MAX_SAFE_INTEGER is deliberate. This is because in the future Number.MAX_SAFE_INTEGER could be raised to 2 ** 66 or some value larger 2 ** 63.
seebees
force-pushed
the
max_bytes_per_key
branch
from
f5e3805 to
5d1ae29
Compare
mattsb42-aws
requested changes
Aug 22, 2019
mattsb42-aws
requested changes
Aug 23, 2019
Co-Authored-By: Matt Bullock <bullocm@amazon.com>
Co-Authored-By: Matt Bullock <bullocm@amazon.com>
mattsb42-aws
requested changes
Aug 27, 2019
Co-Authored-By: Matt Bullock <bullocm@amazon.com>
mattsb42-aws
approved these changes
Aug 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maximum number of bytes which are allowed to be encrypted under a single data key
The real maximum is 2 ** 63 - 1,
However Javascript can only perform safe operations on values
up to Number.MAX_SAFE_INTEGER === 9007199254740991 === 2 ** 53 - 1.
e.g
Number.MAX_SAFE_INTEGER + 1 === Number.MAX_SAFE_INTEGER + 2 => true
Number.MAX_SAFE_INTEGER + 1 > Number.MAX_SAFE_INTEGER + 2 => false
Number.MAX_SAFE_INTEGER + 1 < Number.MAX_SAFE_INTEGER + 2 => false
This means that after 2 ** 53 - 1 the process of accumulating a byte count
will never yield an accurate comparison and so, never halt.
The choice here to use 2 ** 53 - 1 instead of Number.MAX_SAFE_INTEGER is deliberate.
This is because in the future Number.MAX_SAFE_INTEGER could be raised to 2 ** 66
or some value larger 2 ** 63.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: