test: Condition tests for caching-materials-manager-browser #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lavaleri
reviewed
Jul 30, 2019
| @@ -59,4 +59,28 @@ describe('WebCryptoCachingMaterialsManager', () => { | |||
| expect(test._maxBytesEncrypted).to.equal(maxBytesEncrypted) | |||
| expect(test._maxMessagesEncrypted).to.equal(maxMessagesEncrypted) | |||
| }) | |||
|
|
|||
| it('Precondition: A partition value must exist for WebCryptoCachingMaterialsManager.', () => { | |||
There was a problem hiding this comment.
Does this test also need to be added to caching_materials_manager_node.test.ts ?
There was a problem hiding this comment.
Yes, and it is in a different PR
| /* Binary data is being transformed to utf-8. | ||
| * This means it is highly likely to be less than 64 characters long. | ||
| */ | ||
| expect(test._partition).to.be.a('string').and.to.have.length.greaterThan(50) |
There was a problem hiding this comment.
What is the likelihood that 64 bytes of random data -> UTF-8 will be less than 50 characters? Enough that we will "never" see this test fail?
There was a problem hiding this comment.
Sigh... I "fixed" this in https://github.com/awslabs/aws-encryption-sdk-javascript/pull/178/files#diff-2e3dd129c30c2285d72b61362efd41b9R58
Once that is merged. I'll update the test... utf8 on random data is.... sub optimal.
lavaleri
suggested changes
Aug 2, 2019
| maxAge | ||
| }) | ||
| /* Binary data is being transformed to utf-8. | ||
| * This means it is highly likely to be less than 64 characters long. |
There was a problem hiding this comment.
This comment is no longer needed
lavaleri
approved these changes
Aug 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: