test: better code coverage reports #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istanbul wanted a `sourceRoot` property to map back the sourceMaps with. This makes `nyc merge` work. This means that all code coverage can now be merged into a single report. Also remove the lower line coverage and change the process chaining to `&&` so that CI will _always_ fail.
karlw00t
previously approved these changes
Jul 25, 2019
karlw00t
approved these changes
Jul 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
istanbul wanted a
sourceRootproperty to map back the sourceMaps with.This makes
nyc mergework.This means that all code coverage can now be merged into a single report.
Also remove the lower line coverage
and change the process chaining to
&&so that CI will always fail.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: