feat: Encryption tests for integration-browser #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/awslabs/aws-crypto-tools-test-vector-framework defines an encryption manifest. This manifest should be used to maintain cross compatibility of language implementations. Then integrate this into the CI integration tests. Also update package.json to better organize parameters.
johnwalker
reviewed
Jul 24, 2019
ragona
previously approved these changes
Jul 24, 2019
| needs(response.ok, `Failed to decrypt: ${toUtf8(body)}`) | ||
| expect(plainText).toEqual(new Uint8Array(body)) | ||
| } catch (e) { | ||
| if (!notSupportedMessages.includes(e.message)) throw e |
There was a problem hiding this comment.
I don't suppose there's a better way to handle specific error types that isn't just string parsing? It looks like if one of those error messages changes the logic here breaks.
There was a problem hiding this comment.
There maybe. But that would be an extensive change to the ESDK that I may make...
| import got from 'got' | ||
|
|
||
| export async function buildEncryptFixtures (fixtures: string, manifestFile: string, keyFile: string, testName: string, slice: string) { | ||
| const [start = 0, end = 9999] = (slice || '').split(':').map(n => parseInt(n, 10)) |
There was a problem hiding this comment.
Nitpick: This smells funny.
There was a problem hiding this comment.
Very funny. Just me working around some cmd line parsing :(
Humans are difficult interfaces...
johnwalker
previously approved these changes
Jul 24, 2019
mattsb42-aws
approved these changes
Jul 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/awslabs/aws-crypto-tools-test-vector-framework defines an encryption manifest.
This manifest should be used to maintain cross compatibility of language implementations.
Then integrate this into the CI integration tests.
Also update package.json to better organize parameters.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.