fix: frame length can not be 0 #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolves aws#129 The other ESDK’s use frameLength === 0 to indicate non-framed content. The JS ESDK does not support encrypting non-framed content. A frameLength of 0 will crash the process. Add condition and test.
mattsb42-aws
requested changes
Jul 16, 2019
| @@ -60,6 +62,10 @@ export async function encrypt ( | |||
| plaintext: Uint8Array, | |||
| { suiteId, encryptionContext, frameLength = FRAME_LENGTH }: EncryptInput = {} | |||
| ): Promise<EncryptResult> { | |||
|
|
|||
| /* Precondition: The frameLength must be less than the maximum frame size for browser encryption. */ | |||
| needs(frameLength > 0 && Maximum.FRAME_SIZE >= frameLength, 'frameLength out of bounds') | |||
There was a problem hiding this comment.
Can we add those bounds to the error message?
There was a problem hiding this comment.
fixed, in both... :)
seebees
force-pushed
the
frame_length_bounds
branch
from
477689e to
3f91a93
Compare
mattsb42-aws
approved these changes
Jul 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #129
The other ESDK’s use frameLength === 0 to indicate non-framed content.
The JS ESDK does not support encrypting non-framed content.
A frameLength of 0 will crash the process.
Add condition and test.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.