feat: Node.js Typescript version dependency #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolves aws#135 The AWS Encryption SDK should track the Node.js LTS policy. For developers using Typescript and @types/node@8 the ESDK should “just work”. Because some packages export Node.js types like `CipherGCM` developers would be forced to install an unwanted type version. This pulls in the needed parts of the needed types into the packages. It is only the types that differ in this case. Regarding KeyObjects, rsa support is removed, but will be added back in when aws#74 is addressed.
karlw00t
approved these changes
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #135
The AWS Encryption SDK should track the Node.js LTS policy.
For developers using Typescript and @types/node@8
the ESDK should “just work”.
Because some packages export Node.js types like
CipherGCMdevelopers would be forced to install an unwanted type version.
This pulls in the needed parts of the needed types into the packages.
It is only the types that differ in this case.
Regarding KeyObjects, rsa support is removed,
but will be added back in when #74 is addressed.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.