fix: aws sdk version dependencies pollution #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolves aws#136 resolved aws#138 The AWS SDK for JS v2 and v3 have similar types, but they are not exactly the same. In a effort to have both versions work, I imported as dev dependencies all the relevant packages and tried to use conditional types. However, since the types are all exported by the functions this did not work as planed and caused _every_ client to want _every_ SDK. The interface the AWS Encryption SDK for JS needs from the AWS SDK is minimal. Hand rolling the appropriate types is the best solution at this time.
AllanZhengYP
approved these changes
Jul 12, 2019
karlw00t
approved these changes
Jul 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #136
resolved #138
The AWS SDK for JS v2 and v3 have similar types,
but they are not exactly the same.
In a effort to have both versions work,
I imported as dev dependencies all the relevant packages
and tried to use conditional types.
However, since the types are all exported by the functions
this did not work as planed and caused every client to want every SDK.
The interface the AWS Encryption SDK for JS needs
from the AWS SDK is minimal.
Hand rolling the appropriate types is the best solution at this time.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.