Making client suppliers composable #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seebees
reviewed
Mar 11, 2020
| @@ -73,10 +72,10 @@ public MultiRegionRecordPusherExample(final Region[] regions, final String kmsAl | |||
| .build()); | |||
|
|
|||
| keyrings.add(StandardKeyrings.awsKmsBuilder() | |||
| .awsKmsClientSupplier(AwsKmsClientSupplier.builder() | |||
| .awsKmsClientSupplier(new AllowRegionsAwsKmsClientSupplier(Collections.singleton(region.getName()), | |||
There was a problem hiding this comment.
You have all of these nice builders, why is this one new?
There was a problem hiding this comment.
Seemed like it might be overkill to have a builder here, but I can make one too. I wasn't really satisfied with the mix of builders and constructors either
|
|
||
| private AWSCredentialsProvider credentialsProvider; | ||
| private ClientConfiguration clientConfiguration; | ||
| private final Map<String, AWSKMS> clientsCache = new HashMap<>(); |
There was a problem hiding this comment.
This doesn't look to be thread-safe. Should this be a ConcurrentHashMap?
There was a problem hiding this comment.
Good point, I'll make it ConcurrentHashMap. The RegionalClientSupplier that MKPs use also used a ConcurrentHashMap
src/main/java/com/amazonaws/encryptionsdk/kms/StandardAwsKmsClientSuppliers.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Making the Aws KMS client suppliers composable to match the design of the Python and JS ESDKs
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: