Define an enum for the RSA padding scheme #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SalusaSecondus
suggested changes
Mar 9, 2020
| return new RawRsaKeyring(keyNamespace, keyName, publicKey, privateKey, paddingScheme); | ||
| } | ||
|
|
||
| public enum RsaPaddingScheme { |
There was a problem hiding this comment.
NitPick: For ease of use, calculate the correct OAEPParameterSpec instances for each of these (they are immutable) and just pull them from the enum.
There was a problem hiding this comment.
I'll hold off on this until Master Keys are deleted
Comment on lines
+118
to
+119
| * The Cipher transformation standard name as specified in | ||
| * https://docs.oracle.com/javase/8/docs/technotes/guides/security/StandardNames.html#Cipher |
There was a problem hiding this comment.
This is almost correct. Please clarify that in all cases the hash function used with MGF1 is the same as the hash function used directly with the message.
SalusaSecondus
approved these changes
Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Define an enum for the RSA padding scheme #160
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: