Define the MultiKeyring #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| MultiKeyring(Keyring generatorKeyring, List<Keyring> childrenKeyrings) { | ||
| this.generatorKeyring = generatorKeyring; | ||
| this.childrenKeyrings = childrenKeyrings == null ? emptyList() : unmodifiableList(childrenKeyrings); |
There was a problem hiding this comment.
Might be worth making a defensive copy of childrenKeyrings. unmodifiableList keeps you from modifying it, not anyone else.
There was a problem hiding this comment.
Done. I'll make this change in the KmsKeyring too
src/main/java/com/amazonaws/encryptionsdk/keyrings/StandardKeyrings.java
Show resolved
Hide resolved
lavaleri
reviewed
Dec 17, 2019
SalusaSecondus
approved these changes
Dec 18, 2019
seebees
reviewed
Dec 19, 2019
Comment on lines
+65
to
+70
| requireNonNull(decryptionMaterials, "decryptionMaterials are required"); | ||
| requireNonNull(encryptedDataKeys, "encryptedDataKeys are required"); | ||
|
|
||
| if (decryptionMaterials.hasPlaintextDataKey()) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
These are all important for every keyring.
The fact that this code is here in the MultiKeyring implies to me that it will need to be in every keyring?
While not the end of the world,
this does mean that if we have people write their own keyring
they will need to remember to include this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change contains the initial implementation of the Multi Keyring.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: