Create keyring trace and add to encryption and decryption materials. #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Issue #, if available:* #102 *Description of changes:* Creating a keyring trace and adding to encryption and decryption materials to allow for auditing actions a keyring has taken on encryption materials. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. # Check any applicable: - [ ] Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.
src/test/java/com/amazonaws/encryptionsdk/keyrings/KeyringTraceTest.java
Show resolved
Hide resolved
Comment on lines
38
to
49
| /** | ||
| * A flag to represent that the keyring has cryptographically | ||
| * bound the encryption context to a newly created encrypted data key. | ||
| */ | ||
| WRAPPING_KEY_SIGNED_ENC_CTX, | ||
|
|
||
| /** | ||
| * A flag to represent that the keyring has verified that an encrypted | ||
| * data key was originally created with a particular encryption context. | ||
| */ | ||
| WRAPPING_KEY_VERIFIED_ENC_CTX | ||
| } |
There was a problem hiding this comment.
Thoughts on changing these names to spell out "encryption context"? I know these are the magic strings that we've used to date, but since we decided we're not worrying about communicating them across implementations I kind of want to go back in the Python implementation and expand this.
There was a problem hiding this comment.
Sounds good to me. And actually the spec already spells out the word anyway (https://github.com/awslabs/aws-encryption-sdk-specification/blob/master/framework/structures.md#flags). I'll get rid of the "WRAPPING_KEY_" part too, I don't think that is adding much
mattsb42-aws
approved these changes
Oct 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #102
Description of changes:
Creating a keyring trace and adding to encryption and decryption materials to allow for auditing actions a keyring has taken on encryption materials.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: