Add support for running tests on OSX and Windows #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify the copy-dependencies plugin configuration to copy dlls, dylibs, and .so's to the test-lib directory so that tests can be run on more platforms. Switch the phase to test-compile, since the libs aren't a compilation requirement. Update the maven surefire dependency and disable the system classloader for tests for this bug in some versions of the JDK (like on ubuntu right now): https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=911925
|
The reason the linux native dependency doesn't show in the diff is because it was already there. Linux tests continue to work after this change. |
mattsb42-aws
approved these changes
Dec 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the copy-dependencies plugin configuration to copy dlls, dylibs,
and .so's to the test-lib directory so that tests can be run on more platforms.
Switch the phase to test-compile, since the libs aren't a compilation
requirement.
Update the maven surefire dependency and disable the system classloader for
tests for this bug in some versions of the JDK (like on ubuntu right now):
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=911925
Tested on Ubuntu and OSX, not sure whether Windows works since I didn't try but it should.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.