Skip to content

Function.py #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 9, 2023
Merged

Function.py #83

merged 4 commits into from
Nov 9, 2023

Conversation

ssnskar
Copy link
Contributor

@ssnskar ssnskar commented Nov 6, 2023

Added the python code snippet of Tutorial: Using Lambda with Amazon SQS as per : https://app.asana.com/0/1203681999313912/1205789652274515

Issue #, if available: #85

Description of changes:
Added the python code snippet of "Tutorial: Using Lambda with Amazon SQS" to integration-sqs-to-lambda as per : https://app.asana.com/0/1203681999313912/1205789652274515

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Added the python code snippet of Tutorial: Using Lambda with Amazon SQS as per : https://app.asana.com/0/1203681999313912/1205789652274515
@boyney123
Copy link
Contributor

Thank you @ssnskar

Can you please update the snippet-data.json file within this snippet folder please? Add this file and lang to the array inside there.

@ssnskar
Copy link
Contributor Author

ssnskar commented Nov 7, 2023

Updated the snippet-data.json . Let me know if any other action is need from my end.

Copy link

@eldritchideen eldritchideen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be more consistent with other examples if the lambda_handler function was at the top of the snippet with the process_message function following.

Changed the position of the Lambda Handler.
@ssnskar
Copy link
Contributor Author

ssnskar commented Nov 8, 2023

Done. Changed the position of the Lambda Handler. Kindly confirm and let me know if anything else is required.

@@ -0,0 +1,13 @@
def lambda_handler(event, context):

Copy link

@eldritchideen eldritchideen Nov 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this blank line. Looks good apart from this item.

Removed Blank space.
@ssnskar
Copy link
Contributor Author

ssnskar commented Nov 8, 2023

Removed blank space.

@boyney123
Copy link
Contributor

Thanks!

@boyney123 boyney123 merged commit 218e553 into aws-samples:main Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants