Added Python Handler file for Lambda Kinesis Integration #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthi-j
suggested changes
Dec 12, 2023
| import json | ||
| import boto3 | ||
| def lambda_handler(event, context): | ||
| kinesis = boto3.client('kinesis') |
There was a problem hiding this comment.
kinesis client initialised but not used. Remove.
| print(f"An error occurred {e}") | ||
| raise e | ||
| print(f"Successfully processed {len(event['Records'])} records.") | ||
| def get_record_data(payload): |
There was a problem hiding this comment.
Don't need a separate function for just decoding. This can be pulled into handler logic.
| print(f"Successfully processed {len(event['Records'])} records.") | ||
| def get_record_data(payload): | ||
| data = base64.b64decode(payload['data']).decode('utf-8') | ||
| # Placeholder for actual async work, you can use asyncio or threading for that |
There was a problem hiding this comment.
Don't see need to recommend asyncio or threading. Remove comment.
| @@ -0,0 +1,19 @@ | |||
| import base64 | |||
| import json | |||
| @@ -0,0 +1,19 @@ | |||
| import base64 | |||
| import json | |||
| import boto3 | |||
There was a problem hiding this comment.
Remove import. See comment for kinesis client below.
|
Updated main.py as per the review suggestion. |
|
Thanks for the review, will merge this in now. |
boyney123
reviewed
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue #, if available: #101
*Description of changes: Added Python Handler file for Lambda Kinesis Integration
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.