Skip to content

chore(commons): consolidate boolean parsing #3970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2025

Conversation

dreamorosi
Copy link
Contributor

Summary

Changes

Please provide a summary of what's being changed

This PR removes the getTruthyBooleanFromEnv and getFalsyBooleanFromEnv that were added in #3945 in favor of a more powerful and extended getBooleanFromEnv helper that can now handle both regular true/false values but also optionally other falsy/truthy values like on, off, yes, no, and so on.

A longer explanation of the change can be found in the linked issue. Thank you @benjymoses for flagging this and proposing this implementation.

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: closes #3967


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi self-assigned this May 23, 2025
@boring-cyborg boring-cyborg bot added commons This item relates to the Commons Utility tests PRs that add or change tests labels May 23, 2025
@pull-request-size pull-request-size bot added the size/L PRs between 100-499 LOC label May 23, 2025
@dreamorosi dreamorosi requested a review from am29d May 23, 2025 14:05
Copy link
Contributor

@am29d am29d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner version now, thanks for the PR!

Copy link

@dreamorosi dreamorosi merged commit 27aa289 into main May 23, 2025
41 checks passed
@dreamorosi dreamorosi deleted the chore/envUtils-consolidate-bools branch May 23, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commons This item relates to the Commons Utility size/L PRs between 100-499 LOC tests PRs that add or change tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: consolidate env variable helpers for booleans
2 participants