chore(commons): consolidate boolean parsing #3970
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
This PR removes the
getTruthyBooleanFromEnv
andgetFalsyBooleanFromEnv
that were added in #3945 in favor of a more powerful and extendedgetBooleanFromEnv
helper that can now handle both regulartrue
/false
values but also optionally other falsy/truthy values likeon
,off
,yes
,no
, and so on.A longer explanation of the change can be found in the linked issue. Thank you @benjymoses for flagging this and proposing this implementation.
Issue number: closes #3967
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.