Skip to content

fix(ci): documentation generation on on-release.yml workflow #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 31, 2021

Conversation

ijemmy
Copy link
Contributor

@ijemmy ijemmy commented Dec 29, 2021

Description of your changes

How to verify this change

I've run this workflow in a feature branch. You can verify output in this site: https://awslabs.github.io/aws-lambda-powertools-typescript/latest/

Related issues, RFCs

#365
#367

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published in downstream module
  • The PR title follows the conventional commit semantics

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ijemmy ijemmy requested review from flochaz and saragerion December 29, 2021 13:08
# This is to prevent "race-condition" in publishing a new version of doc to `gh-pages` (#365)
#########################
concurrency:
group: on-release-publish
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ijemmy ijemmy merged commit bb887fa into main Dec 31, 2021
@ijemmy ijemmy deleted the feat/fix-doc-latest-alias branch December 31, 2021 10:59
@heitorlessa heitorlessa changed the title fix: documentation generation on on-release.yml workflow fix(ci): documentation generation on on-release.yml workflow Jan 5, 2022
@heitorlessa heitorlessa added the internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) label Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants